This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Update Payouts API to v1.2 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypatel512
suggested changes
Oct 13, 2016
| * | ||
| * @package PayPal\Api | ||
| * | ||
| * @property string op | ||
| * @property string path | ||
| * @property mixed value | ||
| * @property string value |
There was a problem hiding this comment.
This will actually be a mixed type. It basically means, it could be anything more or less. The value could be a string or an integer based on what you are patching.
| * | ||
| * @return string | ||
| * @return \PayPal\Api\DefinitionsRecipientEnum |
There was a problem hiding this comment.
This is still a string for us. No concept of Enum as such in PHP SDK.
There was a problem hiding this comment.
Whoops! Missed that one
sdcoffey
force-pushed
the
payouts-v1.2
branch
from
0997a5f
to
0f3a5e6
Compare
jaypatel512
approved these changes
Oct 17, 2016
|
Not sure if any samples requires to be changed. Otherwise, LGTM. |
|
Yeah, most of the updates are in description comments - merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items: