common interface for android and ios #265

alizelzele · 2016-03-23T09:58:16Z

As discussed in #259 , this is a fork for having a common interface for both Android and Ios.
this PR contains the changes required to do the job. this Pr contains the following changes:
1- adding a new android project to sample-apps which is more like the IOS sample app version for testing.
2- changing code generator to support new system and generate files according to new requirement.
3- creating new common elements interfaces and implementing them for ios and android.
4- changing yaml reader to be able to read new style of yaml files.
5- adding some config properties for selecting platform and setting MobileElement annotation parameters from test suite.
6- changing config builder to support selenium grid with multiple appium instances with diferent platforms.
7- adding some test cases and a suite for testing if new system works properly.

Please let me know if any other change is required.

mach6 · 2016-03-23T17:15:04Z

@alizelzele Please update your PR. It needs to be able to compile. It looks like you are missing some files. Also, please squash your commits down to no more than 3 salient commits. Thanks!

mach6 · 2016-03-23T17:18:30Z

@alizelzele Also fyi, our commit comment format is as follows;

Short description on a single line. 
{empty line}
Detailed description. Can span many lines

mach6 · 2016-03-23T17:24:03Z

@alizelzele Was there no way to add the new android page objects functionality/needs into the existing app? How difficult would it be to do this? I'm trying to minimize confusion for anyone looking (developer, other) at our test apps.. To me, it is much less confusing to have one clear app for iOS and another for Android. At a minimum, can you give the new app a name (and corresponding top level directory) which better conveys the difference when compared to the pre-existing android page objects app?

mach6 · 2016-03-23T17:26:06Z

@kumaravel-jayakumar @fakrudeen78 @sundaramrajendran @sebady I'm going to need some help reviewing this one, please :)

mach6 · 2016-03-23T17:32:17Z

Note for reviewers:

[X] @alizelzele covered by the CLA. CLA signed.

mach6 · 2016-03-23T17:41:15Z

@alizelzele Please correct your [user.name] in your ~/.gitconfig. Your commits use

 "ali.kia" <ali.kia@symbio.com>

Or contribution policy asks that you set your [user.name] to be your full name with proper use of case and punctuation.. Here's a good writeup on how to set this - https://help.github.com/articles/setting-your-username-in-git/

to fix this in your existing commits, you will have to amend your commits and reset the author

alizelzele · 2016-03-24T10:36:22Z

@mach6 Sorry, i did not know where to answer to your comments, so i add a comment here.
1- copyrights are changed and fixed.
2- sorry about compile problem. i forgot to add a test page file to git. it is added now.
3- i will squash them as soon as i solve naming with android app.
4- the new Android app is almost the same as ios version for testing porpose, if i had changed the previous app, there would be lots of changes and lots of test cases would need to be updated, so i decided to but it that way. but for sure, it could have a better name. i am not good with naming ( ;) ), do you have any suggestion for the name of new app, or you think it worth to make it only one app and change test cases according to that one?
5- after i squash them all into one commit, the user.name problem will be solved.

thank you.

sebady · 2016-03-25T03:43:13Z

client/src/main/java/com/paypal/selion/internal/platform/pageyaml/YamlV1Reader.java

+    @Override
+    public Map<String, String> getGuiMap(String locale, WebDriverPlatform platform) {
+        return getGuiMap(locale);
+    }


we're ignoring platform param here?

@sebady from comment in com.paypal.selion.reader.YamlV1Reader(line 56), i figured out mobile platform does not need to be supported in yamV1 and i remember i saw somewhere yamlV1 is deprecated if i am not wrong. does it needs to support mobile platform?

alizelzele · 2016-03-25T09:55:25Z

@mach6 i changed the old test cases to work with the new android app and removed the old one.
@sebady from com.paypal.selion.reader.YamlV1Reader(line 56) that says PageYAML V1 only needs to support platform = web and some where that i do not actually remember that was saying "Yaml V1 is deprecated" i figured out it is not required to add this functionality to this version and only V2 is enough. shall i add this functionality to V1 too?

mach6 · 2016-03-26T02:03:38Z

@alizelzele please do not update PageYaml V1.. Yes, it is deprecated (and undocumented) .. It will be removed in a future release.
also, thank you for updating the android tests.

mach6 · 2016-03-29T21:14:46Z

Hi @alizelzele fyi, I'm still waiting for your updates -- squashed commits, etc. cheers.

alizelzele · 2016-03-30T06:12:20Z

@mach6 sorry i was waiting for review and comments before squashing them all to one.
i will do that ASAP.

mach6 · 2016-03-30T07:01:20Z

Thanks @alizelzele .. It makes it easier on the reviewer(s) when the changes are in a single (or 3 max) commits (and corresponding diffs) to go through each change.. It enables us to review them offline without also cross-referencing the output on github and the PR

alizelzele · 2016-03-30T07:40:01Z

@mach6 It was a bit scary to force push to server, but it is done now. :-)
Hope i did not broke anything while force pushing :-)
It is my first time forking and pull requesting. I did not know about making that easier for reviewers and others by making it only one commit. Sorry for late reset.

mach6 · 2016-04-05T21:36:16Z

codegen/src/main/java/com/paypal/selion/plugins/CodeGeneratorMojo.java

@@ -111,8 +114,11 @@ public void setIosCustomElements(String[] elements) {
    public void setAndroidCustomElements(String[] elements) {
        androidCustomElements = Arrays.asList(elements);
    }
-
-
+


@alizelzele don't worry about this one

alizelzele · 2016-04-06T10:27:39Z

codegen/src/main/java/com/paypal/selion/plugins/CodeGeneratorMojo.java

@@ -111,8 +114,11 @@ public void setIosCustomElements(String[] elements) {
    public void setAndroidCustomElements(String[] elements) {
        androidCustomElements = Arrays.asList(elements);
    }
-
-
+


@mach6 I amend commit the changes for code quality.

alizelzele · 2016-04-07T02:28:00Z

codegen/src/main/java/com/paypal/selion/plugins/CodeGeneratorMojo.java

@@ -111,8 +114,11 @@ public void setIosCustomElements(String[] elements) {
    public void setAndroidCustomElements(String[] elements) {
        androidCustomElements = Arrays.asList(elements);
    }
-
-
+


@mach6 I solved all issues in codacy, but it still fails. Am i missing something?

you're okay. you fixed them all but this one. this reports show it -- https://www.codacy.com/app/SeLion/paypal-SeLion/pullRequest?prid=212622

Please don't fix this one. You followed the pattern the file had here. So, we will make an exception

mach6 · 2016-04-12T01:56:54Z

client/src/test/java/com/paypal/selion/android/sample/AppiumAndroidButtonLongClickTest.java

-    private static final String ACTION_BUTTON_LOCATOR = "com.paypal.selion.pageobjectsdemoapp:id/action_button";
-    private static final String LONG_PRESS_BUTTON_LOCATOR = "com.paypal.selion.pageobjectsdemoapp:id/long_press_button";
-    private static final String TEXT_VIEW_LOCATOR = "com.paypal.selion.pageobjectsdemoapp:id/long_press_button_output";
+    private static final String ACTION_BUTTON_LOCATOR = "com.symbio.pageobject:id/btnNext";


please make these all com.paypal.selion

mach6 · 2016-04-12T02:53:25Z

@alizelzele will you please submit a PR for the doc updates that coincide with this PR's feature changes? Documentation is on the gh-pages branch. Thanks!

alizelzele · 2016-04-13T08:49:43Z

@mach6 I changed all the parts you asked for except the documentation part.
is documentation essential for pull request? since it is in another branch i thought maybe it can be done later.

mach6 · 2016-04-13T21:11:19Z

@alizelzele Thanks. The documentation will be needed though it will not prevent this PR from moving forward. This said, I'd like to minimize the gap between merging this PR and the documentation updates. So, if you could please start the changes on your gh-pages branch and work towards opening a new PR, I would appreciate it. Also, pending doc changes could help those of us reviewing this PR understand the approach a bit better. :)

1. adding a common interface for both android and ios objects 2. changing yaml reader and code generator to support new interface and yaml files. 3. add more elements to Android elements. 4. add parameters to config Mobile annotation parameters from suite and command line. 5. creating new android test app that match with ios test app to be able to test common interface. 6. adding test suites and test cases for testing common interface and updating old test cases to be able to work with new one.

mach6 · 2016-05-11T01:25:58Z

codegen/src/main/java/com/paypal/selion/plugins/CodeGeneratorMojo.java

+     *
+     * @parameter expression="${selion-code-generator.mobileCustomElements}"
+     */
+    private List<String> mobileCustomElements;


@alizelzele fyi, you will be impacted here in a minor way by #287 if/when it is merged.
We can fix when before we merge your PR.

mach6 · 2016-05-31T22:56:41Z

client/src/test/java/com/paypal/selion/mobile/sample/mobile/TouchPage.java

@@ -0,0 +1,130 @@
+package com.paypal.selion.mobile.sample.mobile;


Needs a copy of the copyright

mach6 · 2016-05-31T23:00:46Z

@alizelzele fyi - I'm working on this code. I have rebased / merged it with the latest changes on develop .. My goal is to move it to a branch on this repo for final review and merge it asap.

Here is the start of this work -- https://github.com/mach6/SeLion/commits/alizelzele-develop

I might reach out to you for some more help. Hope that is okay!

alizelzele · 2016-06-02T05:30:55Z

@mach6 Sure, let me know how i can be of any help.

mach6 · 2016-06-03T21:39:08Z

@alizelzele @sebady Moved this PR to the local branch https://github.com/paypal/SeLion/tree/alizelzele-develop for final readiness. Also opened #296 for further tracking/review

mach6 added enhancement component: client component: codegen labels Mar 23, 2016

sebady reviewed Mar 25, 2016
View reviewed changes

alizelzele force-pushed the develop branch from bbdb368 to d735cb8 Compare March 30, 2016 07:30

mach6 reviewed Apr 5, 2016
View reviewed changes

alizelzele force-pushed the develop branch from d735cb8 to 7f216bb Compare April 6, 2016 10:06

alizelzele reviewed Apr 6, 2016
View reviewed changes

alizelzele force-pushed the develop branch from 7f216bb to 1b6a91c Compare April 7, 2016 01:37

alizelzele reviewed Apr 7, 2016
View reviewed changes

mach6 reviewed Apr 12, 2016
View reviewed changes

alizelzele force-pushed the develop branch from 1b6a91c to aad09d0 Compare April 13, 2016 08:26

alizelzele force-pushed the develop branch from aad09d0 to a7160cc Compare April 13, 2016 08:56

alizelzele force-pushed the develop branch from a7160cc to c092052 Compare April 22, 2016 08:06

alizelzele mentioned this pull request Apr 25, 2016

Update SeLion document with mobile platform, common interface for and… #278

Closed

alizelzele force-pushed the develop branch from c092052 to cc9aea8 Compare April 28, 2016 08:24

alizelzele force-pushed the develop branch from cc9aea8 to 1074284 Compare May 6, 2016 04:13

mach6 reviewed May 11, 2016
View reviewed changes

mach6 added this to the 1.1.0 milestone May 11, 2016

mach6 mentioned this pull request May 11, 2016

Error forwarding the new session cannot find : paypal/docker-selion#10

Closed

mach6 reviewed May 31, 2016
View reviewed changes

mach6 mentioned this pull request Jun 3, 2016

MobileElement improvements from PR #265 #296

Closed

mach6 closed this Jun 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

common interface for android and ios #265

common interface for android and ios #265

alizelzele commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

alizelzele commented Mar 24, 2016

sebady Mar 25, 2016

alizelzele Mar 25, 2016

alizelzele commented Mar 25, 2016

mach6 commented Mar 26, 2016

mach6 commented Mar 29, 2016

alizelzele commented Mar 30, 2016

mach6 commented Mar 30, 2016

alizelzele commented Mar 30, 2016

mach6 Apr 5, 2016

alizelzele Apr 6, 2016

alizelzele Apr 7, 2016

mach6 Apr 7, 2016

mach6 Apr 12, 2016

mach6 commented Apr 12, 2016

alizelzele commented Apr 13, 2016

mach6 commented Apr 13, 2016

mach6 May 11, 2016

mach6 May 31, 2016

mach6 commented May 31, 2016

alizelzele commented Jun 2, 2016

mach6 commented Jun 3, 2016

		@@ -0,0 +1,130 @@
		package com.paypal.selion.mobile.sample.mobile;

common interface for android and ios #265

common interface for android and ios #265

Conversation

alizelzele commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

mach6 commented Mar 23, 2016

alizelzele commented Mar 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alizelzele commented Mar 25, 2016

mach6 commented Mar 26, 2016

mach6 commented Mar 29, 2016

alizelzele commented Mar 30, 2016

mach6 commented Mar 30, 2016

alizelzele commented Mar 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mach6 commented Apr 12, 2016

alizelzele commented Apr 13, 2016

mach6 commented Apr 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mach6 commented May 31, 2016

alizelzele commented Jun 2, 2016

mach6 commented Jun 3, 2016