MobileElement improvements from PR #265 #296
Conversation
mach6
changed the title
| import org.apache.commons.lang.StringUtils; | ||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
| import org.openqa.selenium.WebElement; | ||
| import org.openqa.selenium.remote.RemoteWebElement; |
There was a problem hiding this comment.
unused import. Will fix this
mach6
force-pushed
the
alizelzele-develop
branch
from
481731e
to
28068c5
Compare
1. adding a common interface for both android and ios objects 2. changing yaml reader and code generator to support new interface and yaml files. 3. add more elements to Android elements. 4. add parameters to config Mobile annotation parameters from suite and command line. 5. creating new android test app that match with ios test app to be able to test common interface. 6. adding test suites and test cases for testing common interface and updating old test cases to be able to work with new one.
- Also fixed an issue with processing androidCustomElements
usually you want to wait for an element from page file, waits now support elements directly
mach6
force-pushed
the
alizelzele-develop
branch
from
28068c5
to
f54465f
Compare
| private static final String TEXT_FIELD_LOCATOR = "xpath=//UIAApplication[1]/UIAWindow[1]/UIATextField[2]"; | ||
|
|
||
| @Test | ||
| @MobileTest(appPath = "http://localhost:8000/webServer/pageObject.app.zip", device = "iphone:9.3", deviceType = "iPhone 6") |
There was a problem hiding this comment.
This hard-coded path is not ideal
One functional change: - MOBILE_PLATFORM config option no longer case sensitive
|
|
||
| /** | ||
| * it is not accurate and is best to used only for setting value to 0 or 1, otherwise the result is close to number | ||
| * @param value The desired decimal value from 0 to 1, inclusive. A 0 value represents far left and a value of 1 |
There was a problem hiding this comment.
@alizelzele this comment seems incomplete. Will you please update it.. A value of 1, far right?
|
|
||
| @MobileTest | ||
| @Test | ||
| public void testTableClickAndroid() throws Exception { |
There was a problem hiding this comment.
@alizelzele shouldn't this be limited to groups = "android"?
There was a problem hiding this comment.
@mach6 This test will work on both platforms. The method has a wrong name. i will fix it in next commit.
There was a problem hiding this comment.
@alizelzele any progress on the next commit? thanks!
There was a problem hiding this comment.
@mach6 I was waiting for the test fail issue that you reported in AppiumAndroidCheckBoxSeekBarTest.java. creating a pull request now.
|
@alizelzele I have update this pr with your latest commit. I'm doing a little more testing on these changes but will be squashing and merging this branch shortly. |
|
merged |
|
@sebady @alizelzele Thanks for this! |
moved the PR #265 to a local branch and opening this PR for continued tracking.