fix: don't fun button_handleClick in a setTimeout for testing (#439)

* Not run button_handleClick setTimeout for testing(#437)

* Update downshift.js

src/__tests__/downshift.get-button-props.js

@@ -19,12 +19,10 @@ test('space on button opens and closes the menu', () => {
 test('clicking on the button opens and closes the menu', () => {
   const {button, renderSpy} = setup()
   Simulate.click(button)
-  jest.runAllTimers()
   expect(renderSpy).toHaveBeenLastCalledWith(
     expect.objectContaining({isOpen: true}),
   )
   Simulate.click(button)
-  jest.runAllTimers()
   expect(renderSpy).toHaveBeenLastCalledWith(
     expect.objectContaining({isOpen: false}),
   )
@@ -91,6 +89,29 @@ test(`getToggleButtonProps doesn't include event handlers when disabled is passe
   }
 })
 
+describe('Expect timer to trigger on process.env.NODE_ENV !== test value', () => {
+  const originalEnv = process.env.NODE_ENV
+
+  afterEach(() => {
+    process.env.NODE_ENV = originalEnv
+  })
+
+  test('clicking on the button opens and closes the menu for test', () => {
+    process.env.NODE_ENV = 'production'
+    const {button, renderSpy} = setup()
+    Simulate.click(button)
+    jest.runAllTimers()
+    expect(renderSpy).toHaveBeenLastCalledWith(
+      expect.objectContaining({isOpen: true}),
+    )
+    Simulate.click(button)
+    jest.runAllTimers()
+    expect(renderSpy).toHaveBeenLastCalledWith(
+      expect.objectContaining({isOpen: false}),
+    )
+  })
+})
+
 function setup({buttonProps, Button = props => <button {...props} />} = {}) {
   let renderArg
   const renderSpy = jest.fn(controllerArg => {

src/downshift.js

@@ -582,10 +582,17 @@ class Downshift extends Component {
     ) {
       event.target.focus()
     }
-    // Ensure that toggle of menu occurs after the potential blur event in iOS
-    setTimeout(() =>
-      this.toggleMenu({type: Downshift.stateChangeTypes.clickButton}),
-    )
+    // to simplify testing components that use downshift, we'll not wrap this in a setTimeout
+    // if the NODE_ENV is test. With the proper build system, this should be dead code eliminated
+    // when building for production and should therefore have no impact on production code.
+    if (process.env.NODE_ENV === 'test') {
+      this.toggleMenu({type: Downshift.stateChangeTypes.clickButton})
+    } else {
+      // Ensure that toggle of menu occurs after the potential blur event in iOS
+      setTimeout(() =>
+        this.toggleMenu({type: Downshift.stateChangeTypes.clickButton}),
+      )
+    }
   }
 
   button_handleBlur = () => {