Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrollIntoView): take bottom borders into account when scrolling #138

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

arahansen
Copy link
Contributor

@arahansen arahansen commented Aug 12, 2017

What: scrolling offsets now take bottom border into account

Why:
Auto scrolling does not offset enough when using larger borders.

Example:

(dropdown borders exaggerated to demonstrate issue)

Before:
image

After:
image

How:
Added a check for border bottom to the scrollIntoView function

Checklist:

  • Documentation (N/A)
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #138   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         259    260    +1     
  Branches       63     63           
=====================================
+ Hits          259    260    +1
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b8544...981ee20. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent! Thank you!

@kentcdodds kentcdodds merged commit cbd8dc6 into downshift-js:master Aug 12, 2017
@kentcdodds
Copy link
Member

Would you like to add yourself to the contributors table?

@kentcdodds
Copy link
Member

~/Developer/downshift (master)
🏎  $ npm publish --tag rc
+ downshift@1.0.0-rc.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants