Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use onClick handler on items rather than on root #192

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

kentcdodds
Copy link
Member

What: This swaps our document querying stuff from the root element with a more explicit onClick handler on the items.

Why: It probably should have always been this way...

How: Make the changes, see only one test broke, turns out that's unnecessary with the changes now so we can delete it.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table N/A

This should also make it easier to implement #185 馃憤

cc @gricard and @Swizec 馃槃

@codecov-io
Copy link

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #192   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         278    267   -11     
  Branches       65     61    -4     
=====================================
- Hits          278    267   -11
Impacted Files Coverage 螖
src/downshift.js 100% <100%> (酶) 猬嗭笍
src/utils.js 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1b1fd1b...9112f86. Read the comment docs.

Copy link
Collaborator

@tansongyang tansongyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentcdodds kentcdodds merged commit d48031f into master Sep 20, 2017
@kentcdodds kentcdodds deleted the pr/simplify branch November 22, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants