feat: use onClick handler on items rather than on root #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 278 267 -11
Branches 65 61 -4
=====================================
- Hits 278 267 -11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This swaps our document querying stuff from the root element with a more explicit
onClickhandler on the items.Why: It probably should have always been this way...
How: Make the changes, see only one test broke, turns out that's unnecessary with the changes now so we can delete it.
Checklist:
This should also make it easier to implement #185 👍
cc @gricard and @Swizec 😄