Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Dynamic Dataset for BigQuery #259

Closed
anishanainani opened this issue Jan 14, 2021 · 0 comments · Fixed by #260
Closed

[Enhancement] Dynamic Dataset for BigQuery #259

anishanainani opened this issue Jan 14, 2021 · 0 comments · Fixed by #260

Comments

@anishanainani
Copy link
Contributor

What feature are your requesting?
Add support for dynamic dataset for BigQuery in GSQL.

What benefits do you foresee from the feature you are requesting?
SQL access to BigQuery.

Potential solution/ideas?

Additional context
anishanainani added a commit to anishanainani/gimel that referenced this issue Jan 14, 2021
@anishanainani
[paypal#259] Add support for dynamic dataset for BigQuery
1e3b428
@anishanainani anishanainani mentioned this issue Jan 14, 2021
Merged
4 tasks
Dee-Pac pushed a commit that referenced this issue Jan 21, 2021
@anishanainani
[#259] [Connector] [BigQuery] Add support for dynamic dataset for Big…
94653e4 
…Query #260

Make sure you have checked all steps below.

### GitHub Issue
Fixes #259 
Closes #260 

### Checklist:
<!--- Go over all the following points. Check boxes that apply to this pull request -->
- [ ] This pull request updates the documentation
- [ ] This pull request changes library dependencies
- [ ] Title of the PR is of format (example) : [#25][Github] Add Pull Request Template

<!-- NOTE: lines that start with < - - ! and end with - - > are comments and will be ignored. -->
<!-- Please include the GitHub issue number in the PR title above. If an issue does not exist, please create one.-->
<!-- Example:[#25][Github] Add Pull Request Template where [#25 refers to #25] -->

### What is the purpose of this pull request?
Add dynamic dataset support for BigQuery

### How was this change validated?
```import org.apache.spark.sql.{Column, Row, SparkSession,DataFrame}
import org.apache.spark.sql.functions._
// Create Gimel SQL reference
val gsql: (String) => DataFrame = com.paypal.gimel.sql.GimelQueryProcessor.executeBatch(_: String, spark)
gsql("set gimel.logging.level=CONSOLE")

spark.conf.set("gcpAccessToken", "********")
gsql("set gimel.udc.auth.enabled=false")
gsql("set rest.service.method=http")
gsql("set rest.service.host=udc-host")
gsql("set rest.service.port=80")
gsql("select * from udc.bigquery.gcp_project_name.demc_test.date_dim")
```

### Commit Guidelines
- [X] My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#259] [Connector] [BigQuery] Add support for dynamic dataset for BigQuery anishanainani/gimel
1 participant
@anishanainani