Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GitHub] Auto-close GH Issues when PRs are merged #50

Closed
r39132 opened this issue Apr 9, 2018 · 0 comments · Fixed by #52
Closed

[GitHub] Auto-close GH Issues when PRs are merged #50

r39132 opened this issue Apr 9, 2018 · 0 comments · Fixed by #52
Assignees
@r39132
Labels
good first issue Easy for newcomers to pickup and contribute. Gimel internals are not required to be known.

Comments

@r39132
Copy link
Contributor

r39132 commented Apr 9, 2018

As a developer, I would like GH Issues that are fixed to automatically close when the referencing PR is merged.

This can be done by adding a set of reserved words to the body of either the PR or the commit message as described here.

I propose updating the PR template to include this so that we ensure all PRs are compliant with this practice.
@r39132 r39132 self-assigned this Apr 9, 2018
@r39132 r39132 added the good first issue Easy for newcomers to pickup and contribute. Gimel internals are not required to be known. label Apr 9, 2018
@r39132 r39132 mentioned this issue Apr 9, 2018
Merged
5 tasks
@r39132 r39132 closed this as completed in #52 Apr 9, 2018
r39132 pushed a commit that referenced this issue Apr 9, 2018
@r39132
[#50] Auto-close GH Issue when PR is merged
1e15cc1
r39132 added a commit that referenced this issue Apr 10, 2018
@r39132
[#50] Auto-close GH Issue when PR is merged
8a85014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r39132 r39132

Labels
good first issue Easy for newcomers to pickup and contribute. Gimel internals are not required to be known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#50] Auto-close GH Issue when PR is merged
1 participant
@r39132