Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs that PayPalNativeShippingDelegate is sometimes required #150

Merged
merged 4 commits into from
May 15, 2023

Conversation

scannillo
Copy link
Collaborator

@scannillo scannillo commented May 10, 2023

Reason for changes

  • This GH issue raised a question about when a merchant needs to implement the shipping callback. Turns out, it is not entirely optional. There is a case when a merchant must set it to avoid an infinite spinner on their checkout button.
  • Special thanks to @laurentbourg for highlighting this area of improvement 馃憦

Summary of changes

  • Clarify that merchants using GET_FROM_FILE orders must implement PayPalNativeShippingDelegate

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner May 10, 2023 16:45
Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
Copy link

@wallportillo wallportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scannillo these look good to me as well

@scannillo scannillo merged commit e55766f into main May 15, 2023
4 checks passed
@scannillo scannillo deleted the update-shipping-callback-docs branch May 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants