Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs that PayPalNativeShippingListener is sometimes required #140

Merged
merged 2 commits into from
May 15, 2023

Conversation

scannillo
Copy link
Collaborator

Equivalent iOS PR - https://github.com/paypal/iOS-SDK/pull/150

Reason for changes

  • This GH issue raised a question about when a merchant needs to implement the shipping callback. Turns out, it is not entirely optional. There is a case when a merchant must set it to avoid an infinite spinner on their checkout button.

Summary of changes

  • Clarify that merchants using GET_FROM_FILE orders must implement PayPalNativeShippingDelegate

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner May 10, 2023 19:36
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #140 (ff5da9a) into main (25bc012) will not change coverage.
The diff coverage is n/a.

❗ Current head ff5da9a differs from pull request most recent head 6877aed. Consider uploading reports for the commit 6877aed to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #140   +/-   ##
=========================================
  Coverage     32.55%   32.55%           
  Complexity       20       20           
=========================================
  Files            22       22           
  Lines           301      301           
  Branches         21       21           
=========================================
  Hits             98       98           
  Misses          197      197           
  Partials          6        6           
Flag Coverage Δ
card 32.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25bc012...6877aed. Read the comment docs.

@scannillo scannillo force-pushed the update-shipping-callback-docs branch from 9c9d8af to 6877aed Compare May 11, 2023 21:18
@scannillo
Copy link
Collaborator Author

cc: @jcnoriega Can you take a look?

Copy link

@wallportillo wallportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scannillo these look good to me

@scannillo scannillo merged commit b233a67 into main May 15, 2023
6 checks passed
@scannillo scannillo deleted the update-shipping-callback-docs branch May 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants