Dev #98
Merged
Dev #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NeetishPathak
commented
May 12, 2023
NeetishPathak
commented
- Optimizations and code readability fixes
- Addressed Integer overflow issue
Fixed issues found in Cycode Vulnerabilities
verapaypal
previously approved these changes
May 12, 2023
Commenting out all print statements
NeetishPathak
dismissed stale reviews from verapaypal and jostanislas
via
cab57c9
yapingshi
previously approved these changes
May 12, 2023
art2ip
reviewed
May 12, 2023
cmd/proxy/watcher/watcher.go
Outdated
| glog.Infof("markdown: zoneid=%d", zoneid) | ||
| markdownobj.MarkDown(int32(zoneid)) | ||
| } else { | ||
| glog.Errorf("markdown failed. Error:", err.Error()) |
There was a problem hiding this comment.
Message is clearer if it has ... %s Value: %s", err.Error(), string(ev.Kv.Value))
There was a problem hiding this comment.
Addressed this in my latest commit.
Addressed review comments
verapaypal
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.