Configurable favicon in config/middleware.json #47
Conversation
Setting favicon:"" disables express.favicon() so requests can be served as static files, otherwise the value is passed on as favicon file path argument.
|
I'd rather see it be an undefined value rather than an empty string. |
|
It needs to be compared to a specific value if we want to keep backwards compatibility: if we use (!config.favicon), not defining a value in the configuration (the default) would remove the favicon() middleware. I assume there is a reason for it to be there as default. As for the empty string value, in the first version I used plain false which to me made a lot of sense as if saying "do not handle favicons, I'll do that". However, I somehow got confused about the JSON specification when cleaning things up before the pull request and thought that boolean false would not be a valid value; I just checked and it is, so I'll change it back. |
as the way to tell Kraken not to use the favicon middleware. The only reason for switching to an empty string at the last minute was a misunderstanding on my part of the JSON specification.
|
This feature is covered in a better way by #53. |
Setting
favicon:""disables express.favicon() so requests can be served asstatic files, otherwise the value is passed on as favicon file path argument.