This repository has been archived by the owner on Jan 22, 2020. It is now read-only.
Adding a check in click event listener to prevent undefined exception #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grawk
suggested changes
Jul 18, 2017
| @@ -0,0 +1,57 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
@aniljca does this test fail without your change? I notice there are no "click" events, so not sure it would actually encounter the problem.
There was a problem hiding this comment.
@grawk Yes, it does fail without my change. Please see line #12 where I've configured Click events as one of the arguments. The code does reach line #198 with this configuration and fails (without my change) when driver.getSession() returns undefined value, in cases where we have multiple test cases in the suite.
There was a problem hiding this comment.
Great! Thanks for the clarification.
grawk
approved these changes
Jul 18, 2017
| @@ -1,5 +1,9 @@ | |||
| # nemo-screenshot changelog | |||
|
|
|||
| ## v2.2.3 | |||
|
|
|||
| * added a check in click event listener to prevent exception when driver.getSession() returns undefined value. See https://github.com/paypal/nemo-screenshot/pull/57 | |||
gabrielcsapo
approved these changes
Jul 18, 2017
|
@aniljca LGTM! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a check for driver.getSession() value in Click event listener to fix undefined error in certain cases. We were getting the following error without this check when Click capture is configured and test is configured to quit driver after each iteration when more than one test cases were present in the test suite.
TypeError: Cannot read property 'then' of undefined
at index.js:198:36