Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Dissolve API Client and HTTP Request Factories #133

Closed

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • Remove core API class
  • Add SecureTokenServiceAPI
  • Add TrackingEventsAPI
  • Remove HTTP Request Factories and move request building logic into API layer

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #133 (512482a) into main (1fa0b25) will increase coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 512482a differs from pull request most recent head de651b4. Consider uploading reports for the commit de651b4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #133      +/-   ##
============================================
+ Coverage     13.28%   13.42%   +0.13%     
  Complexity        7        7              
============================================
  Files            22       22              
  Lines           301      298       -3     
  Branches         22       22              
============================================
  Hits             40       40              
+ Misses          257      254       -3     
  Partials          4        4              
Flag Coverage Δ
card 13.42% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/com/paypal/android/cardpayments/CardClient.kt 0.00% <0.00%> (ø)
...a/com/paypal/android/cardpayments/api/OrdersAPI.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa0b25...de651b4. Read the comment docs.

@sshropshire sshropshire force-pushed the graphql_remove_generics_and_dissolve_api_client branch from 7825acc to de651b4 Compare May 9, 2023 17:15
Base automatically changed from graphql_remove_generics to main May 9, 2023 17:17
@sshropshire
Copy link
Collaborator Author

Closing in favor of #138

@sshropshire sshropshire closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant