Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Transition Animation #234

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Nav Transition Animation #234

merged 5 commits into from
Jan 18, 2024

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • Adding an explicit transition animation to NavHost to keep screen animations consistent.

Before

screen-20240112-115623.mp4

After

screen-20240112-122053.mp4

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner January 16, 2024 20:44
@sshropshire sshropshire merged commit 331fce6 into main Jan 18, 2024
6 checks passed
@sshropshire sshropshire deleted the nav_transition_animation branch January 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@sarahkoop sarahkoop sarahkoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sshropshire @jaxdesmarais @sarahkoop