Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Demo App Error Handling With SDKSampleServerResult #235

Merged
merged 24 commits into from
Jan 24, 2024
Merged

Improve Demo App Error Handling With SDKSampleServerResult #235

merged 24 commits into from
Jan 24, 2024

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Jan 17, 2024 •
edited
Loading

Summary of changes

  • This PR adds the SDKSampleServerResult type to prevent forced unwrapping of optionals in the Demo app.

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire
Add UseCaseResult type and make all use cases return this type.
4c90919
@sshropshire
Refactor ApproveOrderViewModel and PayPalNativeViewModel to use new U…
6ee68db 
…seCaseResult.
@sshropshire
Refactor PayPalNativeViewModel to use new UseCaseResult type.
6fee0c1
@sshropshire
Refactor PayPalWebViewModel to use UseCaseResult.
df459ac
@sshropshire
Fix build errors from migrating to use case result pattern.
5a88919
@sshropshire
Remove force unwrap in ApproveOrderViewModel.
7191fac
@sshropshire
Update PayPalWebViewModel to use new UseCaseResult pattern.
09f93cc
@sshropshire
Remove function that is no longer needed.
4e1a8e8
@sshropshire
Remove force unwrap in PayPalWebViewModel.
54df953
@sshropshire
Migrate PayPalWebVaultViewModel to use new UseCase pattern.
65b6e13
@sshropshire
Add switchable CompletedActionState to apply a composable when an act…
d63c840 
…ion is completed.
@sshropshire
Refactor demo app to handle use case errors internally.
8f23d0d
@sshropshire
Refactor method name.
b95bbf3
@sshropshire
Remove additional force unwraps.
764af4b
@sshropshire
Migrate action buttons to use new completed state callback.
09b2c96
@sshropshire
Clean up lint errors.
92c2983
@sshropshire
Add extensions for button color in action button column.
736a2d7
@sshropshire
Refactor SDKSampleServerAPI to return UseCaseResults.
204941f
@sshropshire
Update error handling to be centralized.
ff10b2e
@sshropshire
Rename UseCaseResult to SDKSampleServerResult.
83622f0
@sshropshire sshropshire changed the title Improve Demo App Error Handling With UseCaseResult Improve Demo App Error Handling With SDKSampleServerResult Jan 17, 2024
@sshropshire sshropshire marked this pull request as ready for review January 18, 2024 15:49
@sshropshire sshropshire requested a review from a team as a code owner January 18, 2024 15:49
@sshropshire sshropshire merged commit 5731bd6 into main Jan 24, 2024
6 checks passed
@sshropshire sshropshire deleted the use_case_result branch January 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@sarahkoop sarahkoop sarahkoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sshropshire @jaxdesmarais @sarahkoop