Button labels #238
Closed
Button labels #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saperi22
commented
Jan 23, 2024
PaymentButtons/src/main/java/com/paypal/android/paymentbuttons/PayPalButtonLabel.kt
Outdated
Show resolved
Hide resolved
Simplify logic to get label from index.
|
Lint is failing because the existing strings weren't translated into all the new languages we've added. Once we get the translations in, we need to update them in the various strings.xml files for the linter to pass. |
|
DTLOCALZN-25145 - translation ticket. |
|
Design leadership is making changes and we were asked to hold off on these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to PayPal.
DTBTSDK-3266
Summary of changes
Checklist
Authors