-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update demo app Clients from lateinit vars to nullable vars #256
Conversation
These errors are specific to our demo app integration right? I don't quite understand what in the |
Yep, these are crashes due to how the demo app's ViewModels declare the client instances as If merchants followed this pattern in their integration, they'd also need to convert from a lateinit var to a nullable var. |
Should we add more docs to the |
Yeah, I think we can call this out in the devdocs. Have we already made initial updates to the devdocs to add this function? I wouldn't call this a breaking change since the merchant owns the instantiation and management of the client instances. |
Summary of changes
There were crashes in the demo app where lateinit Clients were not getting set either due to a network error or if the activity was cleared without setting the client. These crashes were introduced when the removeObservers() function was added to the clients.
Checklist
Authors