Provide ways to define PayLaterButton color from xml #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saperi22 Do you have more context on why the button changed from extending |
|
@sarahkoop context here: https://github.com/paypal/paypal-android/pull/245/files#r1521937925 |
tdchow
approved these changes
May 21, 2024
sarahkoop
reviewed
May 22, 2024
| @@ -72,6 +75,14 @@ class PayLaterButton @JvmOverloads constructor( | |||
| ) | |||
| } | |||
|
|
|||
| private fun updateColorFrom(typedArray: TypedArray) { | |||
There was a problem hiding this comment.
Not to expand the scope of this PR, but does this same bug exist for the PayPalCreditButton and PayPalButton?
There was a problem hiding this comment.
No, those didn't have changes.
The reason this broke is because of the change in inheritance.
sarahkoop
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Addresses a Live Issue reported by a merchant.
PayLaterButtonnot honoringpaypal_colorattribute in xml.PayLaterButtonused to extend fromPayPalButton, but now it extends fromPaymentButton. I'm providing a new attributepaylater_colorto change the button color in xml.Checklist
Authors
Screenshots