Refactor contingencyFlow zoid component to support JS SDK Reloads #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
requested review from
weihou,
bluepnume,
crookedneighbor and
a team
gregjopa
commented
Sep 14, 2020
| @@ -257,6 +59,6 @@ function start(url : string) : ZalgoPromise<Object> { | |||
| } | |||
|
|
|||
| export default { | |||
There was a problem hiding this comment.
Note that this export default approach is still needed for the unit tests with how testdouble.js works.
mnicpt
approved these changes
Sep 14, 2020
|
Looks great! At some point we should upgrade card-components to use this 3ds component instead: https://github.com/paypal/paypal-common-components/blob/master/src/three-domain-secure/component.jsx -- for now though, this looks like it should work perfectly. Thanks! |
bluepnume
approved these changes
Sep 14, 2020
Ahh good to know about this shared 3ds component. I'll create a ticket for our backlog to get this migrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "listener already exists" error when reloading the JS SDK when using hosted-fields (originally reported here: paypal/paypal-sdk-client#44).
The error is fixed by creating the zoid component in the setupHandler instead so it can be cleaned up in the
destroy()hook to play nice with the setup/destroy workflow of the sdk-client.Additional Info
This PR refactors the zoid component to use the same memoize getter approach that the Buttons component uses. This makes it easy to reference the component in multiple places while only creating it once.
This PR breaks up the contingency flow component into two files. I made this change to make it easier to unit test and to follow the zoid folder pattern used in other repos. I learned that the testdouble.js library considers partial mocks an anti-pattern so having two files avoids the need to partially mock the subject.