New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic messaging #2349
feat: dynamic messaging #2349
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
- Coverage 52.03% 51.75% -0.29%
==========================================
Files 148 149 +1
Lines 11953 12338 +385
Branches 673 703 +30
==========================================
+ Hits 6220 6385 +165
- Misses 5628 5848 +220
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -5,7 +5,7 @@ | |||
"path": "size.min.js", | |||
"compression": "gzip", | |||
"maxPercentIncrease": 3.6, | |||
"maxSize": "77kb" | |||
"maxSize": "79kb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Adds dynamic messaging components to Buttons by leveraging assets from paypal-messaging-components.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Starting with a
paypal.Buttons
component, pass into the param object a message object with props including any of the following:amount
,offer
,color
,position
,align
.Accepted values:
pay_later_short_term
orpay_later_long_term
black
orwhite
top
orbottom
left
orcenter
orright
Screenshots (if applicable)
Dependent Changes (if applicable)
contextual_components
PRs, already merged and deployed)Groups who should review (if applicable)
❤️ Thank you!