Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use message key constants #2372

Merged

Conversation

paypal-rosman
Copy link
Contributor

Description

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 51.73%. Comparing base (3435784) to head (9cea877).

❗ Current head 9cea877 differs from pull request most recent head 4f13d01. Consider uploading reports for the commit 4f13d01 to get more accurate results

Files Patch % Lines
src/zoid/buttons/component.jsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/dynamic-messaging    #2372      +/-   ##
=============================================================
- Coverage                      51.75%   51.73%   -0.02%     
=============================================================
  Files                            149      149              
  Lines                          12338    12342       +4     
  Branches                         703      703              
=============================================================
  Hits                            6385     6385              
- Misses                          5848     5852       +4     
  Partials                         105      105              
Flag Coverage Δ
jest 31.08% <ø> (ø)
karma 54.11% <0.00%> (ø)
vitest 45.52% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seavenly Seavenly changed the title feat: dynamic messaging - final instrumentation changes refactor: use message key constants Apr 8, 2024
@Seavenly Seavenly marked this pull request as ready for review April 8, 2024 20:34
@Seavenly Seavenly requested a review from a team as a code owner April 8, 2024 20:34
@Seavenly Seavenly merged commit b35e97e into feature/dynamic-messaging Apr 8, 2024
1 of 3 checks passed
@Seavenly Seavenly deleted the feature/add-merchant-id-button-message-2 branch April 8, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants