Honey ba #1758
Honey ba #1758
Conversation
This reverts commit 3a5d4b1.
| type: 'boolean', | ||
| queryParam: true, | ||
| required: false, | ||
| default: () => true |
There was a problem hiding this comment.
Why do we need this allowBillingPayments prop in checkout-components? It seems like it could just live in SPB.
There was a problem hiding this comment.
@sioked and I syned on this. I learned that this new prop is for Honey and is needed server-side for SPB.
There was a problem hiding this comment.
I added a quick comment on this prop as well to help clarify for the future, Thanks for the suggestion @gregjopa!
There was a problem hiding this comment.
Comment looks good! Could we copy it to wallet/component.jsx as well?
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
+ Coverage 55.43% 56.95% +1.51%
==========================================
Files 92 93 +1
Lines 1418 1482 +64
Branches 333 342 +9
==========================================
+ Hits 786 844 +58
- Misses 598 603 +5
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
Added new prop to the sdk used for one-click with Honey to avoid using BA for the payment
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
https://engineering.paypalcorp.com/jira/browse/DTCHKINT-746
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Xobuyer: https://github.paypal.com/Checkout-R/xobuyernodeserv/pull/2340
Paypal-smart-payment-buttons:https://github.com/paypal/paypal-smart-payment-buttons/pull/268
❤️ Thank you!