Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) add eslint-config-grumbler to resolve plugin install issue #99

Merged
merged 1 commit into from
May 1, 2024

Conversation

imbrian
Copy link
Contributor

@imbrian imbrian commented May 1, 2024

Fixes issue installing a few eslint-plugin-* packages provided by @krakenjs/eslint-config-grumbler via @krakenjs/grumbler-scripts, where npm is no longer flattening these to node_modules/eslint-plugin-*. eslint then cannot find the plugin. See here.

I did observe that removing mocketeer as a devDependency appears to also resolve this, but this package is used in checkout-components, which is experiencing the same issue.

Possible alternatives:

  • specify all eslint-plugin-* packages from grumbler-scripts
  • determine dependency causing this and use npm overrides to pin version
  • remove mocketeer as dependency
  • use of lockfile to prevent/identify unexpected graph changes due to transitive dependency updates (might not solve the underlying issue, but would prevent the unexpected change).

@imbrian imbrian marked this pull request as ready for review May 1, 2024 14:05
@imbrian imbrian requested a review from a team as a code owner May 1, 2024 14:05
Copy link
Member

@jshawl jshawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: For posterity: It's not clear to me why this is failing all of a sudden:

@imbrian
Copy link
Contributor Author

imbrian commented May 1, 2024

:shipit: For posterity: It's not clear to me why this is failing all of a sudden:

agree. It has to be another transitive dependency that updated, and npm now decides the ideal graph no longer flattens those. mocketeer does specify eslint 5 as a dependency, which I why I looked into that, but still not following the magic behind why that's causing this. That version is not flattened; eslint 8 is at the root.

@imbrian imbrian merged commit 01e13c4 into main May 1, 2024
2 checks passed
@imbrian imbrian deleted the fix-missing-eslint-plugins branch May 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants