Fix Lint Errors #277
Merged
Fix Lint Errors #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
commented
Jun 6, 2024
| @@ -13,6 +13,7 @@ disabled_rules: | |||
| - type_name # tests will have have the format <SUT>_Tests | |||
| - xctfail_message | |||
| - blanket_disable_command | |||
| - non_optional_string_data_conversion | |||
There was a problem hiding this comment.
The places where this rule was being triggered (example here) were places where we were using if let or guard let to safely unwrap these values. There is some debate on reverting and/or changing this rule here so I've opted to disable it for us for now since we are already treating the triggers for this rule safely.
richherrera
approved these changes
Jun 6, 2024
sshropshire
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
[ ] Added a changelog entryAuthors