Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing on and off events for hostedFields #299

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

gregjopa
Copy link
Contributor

This PR improves the types for Hosted Fields by adding support for hostedFieldsInstance.on() and hostedFieldsInstance.off().

Resolves #298

@gregjopa gregjopa requested a review from a team as a code owner November 11, 2022 16:03
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (45fdb0d) compared to base (42645c4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #299   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          138       138           
  Branches        39        39           
=========================================
  Hits           138       138           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gregjopa gregjopa merged commit 216356e into main Nov 11, 2022
@gregjopa gregjopa deleted the hosted-fields-on-off-types branch November 11, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot Access HostedFieldsInstance.on() method without removing type
1 participant