fix: prevent ScrollProvider from causing unnecessary rerender #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeul
approved these changes
Feb 13, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2023
### [1.40.2](v1.40.1...v1.40.2) (2023-03-06) ### Bug Fixes * Accessibility Issue: Messages Space Issue for Screen Reader (DTCRCMERC-1897) ([#907](#907)) ([3e0bef5](3e0bef5)) * prevent ScrollProvider from causing unnecessary rerender ([#899](#899)) ([32a5575](32a5575)) * Screen Reader Issue Messages Paypal Logo (DTCRCMERC-1899) ([#909](#909)) ([47694bf](47694bf)) ### Code Refactoring * support APR disclaimer from modal offers content ([#911](#911)) ([ab01526](ab01526))
|
🎉 This PR is included in version 1.40.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from
useStatetouseRefto keep track of the list of callbacks registered to theScrollProviderto prevent unnecessary top-down rerenders when a callback is added or removed. This swap fromuseStatetouseRefworks because the event of adding and removing scroll event callbacks does not affect the presentation at all that would require a rerender. The code in the callbacks should be the only thing responsible for possibly changing state and requiring a rerender. This change does not impact the frequency or result of the callbacks when called.