Skip to content

Commit

Permalink
fix: Accessibility Issue: Messages Space Issue for Screen Reader (DTC…
Browse files Browse the repository at this point in the history
…RCMERC-1897) (#907)
  • Loading branch information
erikacolette29 authored Mar 6, 2023
1 parent 32a5575 commit 3e0bef5
Show file tree
Hide file tree
Showing 21 changed files with 27 additions and 21 deletions.
2 changes: 1 addition & 1 deletion content/messages/US/generic.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@
["Buy now and pay later.", ["xsmall.2"]]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_multi_eqz.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
[["As low as ${formattedMonthlyPayment}/mo at 0% APR."], ["small", "medium", "large", "xlarge"]]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_multi_eqz_mixed.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
[["As low as ${formattedMonthlyPayment}/mo or 0% APR."], ["small", "medium", "large", "xlarge"]]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_multi_gtz.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
[["As low as ${formattedMonthlyPayment}/mo."], ["small", "medium", "large", "xlarge"]]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_nq_eqz.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_nq_gtz.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_single_eqz.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_single_eqz_mixed.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/long_term_single_gtz.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
[["Make ${total_payments} payments of ${formattedMonthlyPayment}/mo."], ["small", "medium", "large", "xlarge"]]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ezp_multi_eqz.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
]
],
"disclaimer": [
["Learn more", ["default", "small"]],
["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default", "small"]],
[["Min purch req'd. Subject to credit approval.", ["Learn more", "em"]], ["legacy-small"]],
[["Minimum purchase required. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium"]]
]
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ezp_multi_gtz.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
]
],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default", "xsmall"]],
[["Minimum purchase required. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium"]],
[["Min purch req'd. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium.2"]]
]
Expand Down
5 changes: 4 additions & 1 deletion content/messages/US/ppc_ezp_nq_eqz.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["Min purchase required.", ["xsmall.2", "small", "medium", "large", "xlarge"]],
[
"<span aria-hidden='true'>Min purchase required.</span><span class='sr-only'> Min purchase required.</span>",
["xsmall.2", "small", "medium", "large", "xlarge"]
],
[["Min purch req'd. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium"]],
[["Minimum purchase required. Subject to credit approval.", ["Learn more", "em"]], ["legacy-large"]]
]
Expand Down
5 changes: 4 additions & 1 deletion content/messages/US/ppc_ezp_nq_gtz.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["Min purchase required.", ["xsmall.2", "small", "medium", "large", "xlarge"]],
[
"<span aria-hidden='true'>Min purchase required.</span><span class='sr-only'> Min purchase required.</span>",
["xsmall.2", "small", "medium", "large", "xlarge"]
],
[["Minimum purchase required. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium"]],
[["Min purch req'd. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium.2"]]
]
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ezp_single_eqz.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
]
],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default", "xsmall"]],
[["Minimum purchase required. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium"]],
[["Min purch req'd. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium.2"]]
]
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ezp_single_gtz.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
]
],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default", "xsmall"]],
[["Minimum purchase required. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium"]],
[["Min purch req'd. Subject to credit approval.", ["Learn more", "em"]], ["legacy-medium.2"]]
]
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_nq.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"subHeadline": [["Check out with PayPal and choose PayPal Credit.", ["default", "small"]]],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default", "xsmall"]],
[["US customers only. Subject to credit approval", ["Learn more", "em"]], ["legacy-medium"]],
[
"Interest will be charged to your account from the purchase date if the balance is not paid in full within 6 months. Minimum monthly payments required.",
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_nq_xb.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
["xlarge"]
],
[["US customers only. Subject to credit approval", ["Learn more", "em"]], ["legacy-medium"]],
["US only.", ["extra"]],
["<span aria-hidden='true'>US only.</span><span class='sr-only'> US only.</span>", ["extra"]],
["US customers only.", ["extra.2"]]
]
}
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_q.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"subHeadline": [["Check out with PayPal and choose PayPal Credit.", ["default", "small"]]],
"disclaimer": [
["Learn more", ["default", "xsmall"]],
["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default", "xsmall"]],
[["US customers only. Subject to credit approval", ["Learn more", "em"]], ["legacy-medium"]],
[
"Interest will be charged to your account from the purchase date if the balance is not paid in full within 6 months. Minimum monthly payments required.",
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_q_xb.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
["xlarge"]
],
[["US customers only. Subject to credit approval", ["Learn more", "em"]], ["legacy-medium"]],
["US only.", ["extra"]],
["<span aria-hidden='true'>US only.</span><span class='sr-only'> US only.</span>", ["extra"]],
["US customers only.", ["extra.2"]]
]
}
2 changes: 1 addition & 1 deletion content/messages/US/short_term_nq.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@
]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}
2 changes: 1 addition & 1 deletion content/messages/US/short_term_q.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@
]
],
"subHeadline": [],
"disclaimer": [["Learn more", ["default"]]]
"disclaimer": [["<span aria-hidden='true'>Learn more</span><span class='sr-only'> Learn more</span>", ["default"]]]
}

0 comments on commit 3e0bef5

Please sign in to comment.