Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update DE LT disclaimer #1053

Merged
merged 10 commits into from
Feb 26, 2024
Merged

feat: update DE LT disclaimer #1053

merged 10 commits into from
Feb 26, 2024

Conversation

surekhaw
Copy link
Contributor

@surekhaw surekhaw commented Feb 15, 2024 •
edited

Description

fix apr and nominal rate formatting in zeroAPR disclaimer for DE LT to be 0,00% instead of 0.00%
update language

Screenshots

Screenshot 2024-02-14 at 1 47 10 PM

Testing instructions

use DEV_DE_LONG_TERM_0APR account for local testing

@surekhaw surekhaw requested a review from yeul February 15, 2024 16:52
@surekhaw surekhaw marked this pull request as draft February 15, 2024 16:53
@surekhaw surekhaw marked this pull request as ready for review February 16, 2024 17:33
@yeul yeul added snapshots Trigger new snapshots to be generated and removed snapshots Trigger new snapshots to be generated labels Feb 16, 2024
yeul
yeul reviewed Feb 16, 2024
View reviewed changes
utils/devServerProxy/config/DE/index.js Outdated Show resolved Hide resolved
utils/devServerProxy/lib/miscellaneous.js Outdated Show resolved Hide resolved
@yeul yeul added snapshots Trigger new snapshots to be generated and removed snapshots Trigger new snapshots to be generated labels Feb 20, 2024
@yeul yeul added the snapshots Trigger new snapshots to be generated label Feb 20, 2024
@yeul yeul added testing complete approved and removed snapshots Trigger new snapshots to be generated labels Feb 20, 2024
@yeul yeul merged commit 7c34362 into paypal:develop Feb 26, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@semantic-release-bot
chore(release): 1.57.0 [skip ci]
d9214f7 
## [1.57.0](v1.56.0...v1.57.0) (2024-03-05)

### Features

* update DE LT disclaimer ([#1053](#1053)) ([7c34362](7c34362))
* update pm legal disclaimer and disclosure ([#1054](#1054)) ([be9563f](be9563f))
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeul yeul yeul approved these changes

Assignees
No one assigned
Labels
approved released testing complete
Projects
None yet
Milestone
No milestone
2 participants
@surekhaw @yeul