feat: Update DE Pi30 and Ratenzahlung modals to have EN variants #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perco12
changed the title
surekhaw
added
snapshots
perco12
added
snapshots
surekhaw
reviewed
Apr 22, 2024
surekhaw
reviewed
Apr 22, 2024
surekhaw
reviewed
Apr 22, 2024
| @@ -22,6 +22,12 @@ const LOCALE_CONFIG = config[LOCALE]; | |||
| const ACCOUNT_CONFIG = LOCALE_CONFIG[ACCOUNT]; | |||
| const integration = 'standalone'; | |||
| const testFileName = 'longTerm'; | |||
| const ALL_DE_ACCOUNTS = [ | |||
There was a problem hiding this comment.
please add ALL_DE_ACCOUNTS and respective updates to all spec/snapshot-tests subfolders (not just standalone)
surekhaw
reviewed
Apr 22, 2024
| error => console.error(error) // eslint-disable-line no-console | ||
| error => { | ||
| console.error(error); // eslint-disable-line no-console | ||
| return [0, 0]; |
There was a problem hiding this comment.
This shouldn't be necessary. Adding en variants to other test files would have fixed timeout error occurring with previous attempts to update.
surekhaw
approved these changes
Apr 22, 2024
surekhaw
approved these changes
Apr 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
## [1.64.0](v1.63.0...v1.64.0) (2024-04-30) ### Features * purchase protection messsage ([#1075](#1075)) ([c90c280](c90c280)) * Update DE Pi30 and Ratenzahlung modals to have EN variants ([#1076](#1076)) ([c428184](c428184)) ### Code Refactoring * allow mod XO learn more modal inside iframe ([#1079](#1079)) ([5884791](5884791)) * font feature ([#1061](#1061)) ([282c7fe](282c7fe))
|
🎉 This PR is included in version 1.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update DE Modal Pi30 and Paypal Ratenzahlung to have en variants.
Screenshots
Testing instructions
Testing Links will be on the other PRs