Add sendCountMetric to logger #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethmv
force-pushed
the
add-count-metric
branch
from
2bef2ad
to
3634af1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 87.95% 81.83% -6.13%
==========================================
Files 20 21 +1
Lines 490 534 +44
Branches 40 40
==========================================
+ Hits 431 437 +6
- Misses 59 97 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wsbrunson
reviewed
Dec 19, 2023
wsbrunson
approved these changes
Dec 19, 2023
okorye
reviewed
Mar 28, 2024
| @@ -19,3 +19,25 @@ export const getLogger: GetLogger = memoize(() => { | |||
| url: loggerUrl, | |||
| }); | |||
| }); | |||
|
|
|||
| export const sendCountMetric = ({ | |||
There was a problem hiding this comment.
Suggested change
| export const sendCountMetric = ({ | |
| export const sendCountMetric = ({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exact copy of
sendCountMetrichere centrally, it was initially added in SPB but is being used in SDK repos. After this is in we can remove the one temporarily added in checkout-components