feat: rename constant

paypal · Mar 20, 2024 · 1d027b6 · 1d027b6
1 parent 95a29fa
commit 1d027b6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/src/components/PayPalScriptProvider.test.tsx b/src/components/PayPalScriptProvider.test.tsx
@@ -48,7 +48,7 @@ describe("<PayPalScriptProvider />", () => {
             clientId: "test",
             [SCRIPT_ID]: expect.stringContaining("react-paypal-js"),
             [SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE]:
-                SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE_VALUE,
+                SDK_SETTINGS.DATA_LIBRARY_VALUE,
         });
 
         // verify initial loading state
@@ -74,7 +74,7 @@ describe("<PayPalScriptProvider />", () => {
             clientId: "test",
             [SCRIPT_ID]: expect.stringContaining("react-paypal-js"),
             [SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE]:
-                SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE_VALUE,
+                SDK_SETTINGS.DATA_LIBRARY_VALUE,
         });
 
         // verify initial loading state
@@ -140,7 +140,7 @@ describe("<PayPalScriptProvider />", () => {
             clientId: "test",
             [SCRIPT_ID]: expect.stringContaining("react-paypal-js"),
             [SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE]:
-                SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE_VALUE,
+                SDK_SETTINGS.DATA_LIBRARY_VALUE,
         });
 
         expect(state.isPending).toBe(true);

diff --git a/src/components/PayPalScriptProvider.tsx b/src/components/PayPalScriptProvider.tsx
@@ -26,7 +26,7 @@ export const PayPalScriptProvider: FC<ScriptProviderProps> = ({
     const [state, dispatch] = useReducer(scriptReducer, {
         options: {
             [SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE]:
-                SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE_VALUE,
+                SDK_SETTINGS.DATA_LIBRARY_VALUE,
             ...options,
             [SCRIPT_ID]: `${getScriptID(options)}`,
         },
@@ -52,10 +52,7 @@ export const PayPalScriptProvider: FC<ScriptProviderProps> = ({
 
         let isSubscribed = true;
 
-        loadScript({
-            ...state.options,
-            dataJsSdkLibrary: "react-paypal-js",
-        })
+        loadScript(state.options)
             .then(() => {
                 if (isSubscribed) {
                     dispatch({

diff --git a/src/constants.ts b/src/constants.ts
@@ -9,7 +9,7 @@ export const SDK_SETTINGS = {
     DATA_CLIENT_TOKEN: "dataClientToken",
     DATA_USER_ID_TOKEN: "dataUserIdToken",
     DATA_SDK_INTEGRATION_SOURCE: "dataSdkIntegrationSource",
-    DATA_SDK_INTEGRATION_SOURCE_VALUE: "react-paypal-js",
+    DATA_LIBRARY_VALUE: "react-paypal-js",
     DATA_NAMESPACE: "dataNamespace",
 };
 export const LOAD_SCRIPT_ERROR = "Failed to load the PayPal JS SDK script.";

diff --git a/src/context/scriptProviderContext.ts b/src/context/scriptProviderContext.ts
@@ -72,7 +72,7 @@ export function scriptReducer(
                 loadingStatus: SCRIPT_LOADING_STATE.PENDING,
                 options: {
                     [SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE]:
-                        SDK_SETTINGS.DATA_SDK_INTEGRATION_SOURCE_VALUE,
+                        SDK_SETTINGS.DATA_LIBRARY_VALUE,
                     ...action.value,
                     [SCRIPT_ID]: `${getScriptID(action.value)}`,
                 },