New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the div HTML attributes scope #186
Limit the div HTML attributes scope #186
Conversation
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 18 18
Lines 357 357
Branches 110 110
=======================================
Hits 315 315
Misses 42 42 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
In this PR we limit the HTML attributes in the PayPalHostedField component.
In the previous version, the component was receive any kind of random HTML attributes including event handlers.
Not we allow only this list as available props: [id, className, lang, title, style, align].