New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the getErrorMessage function #190
Merged
gregjopa
merged 22 commits into
paypal:main
from
borodovisin:DTPPSDK-388/generateErrorMessage
Oct 15, 2021
Merged
Refactor the getErrorMessage function #190
gregjopa
merged 22 commits into
paypal:main
from
borodovisin:DTPPSDK-388/generateErrorMessage
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 88.16% 90.82% +2.65%
==========================================
Files 18 18
Lines 355 338 -17
Branches 111 100 -11
==========================================
- Hits 313 307 -6
+ Misses 42 31 -11
Continue to review full report at Codecov.
|
westeezy
approved these changes
Oct 11, 2021
gregjopa
reviewed
Oct 11, 2021
gregjopa
reviewed
Oct 12, 2021
gregjopa
reviewed
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the repeated function
getErrorMessage
per component was removed.Now it is a generic function in the
utils.ts
file.The pure function will receive all the needed information to generate and return an error message.
Each component calls the function with specific information, to make a readable message to show to the final user in the UI.