Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified color configuration and fixed bug when no headings or landmarks are on a page #74

Merged
merged 13 commits into from
Jan 25, 2021
Merged

Simplified color configuration and fixed bug when no headings or landmarks are on a page #74

merged 13 commits into from
Jan 25, 2021

Conversation

jongund
Copy link
Collaborator

@jongund jongund commented Jan 15, 2021

No description provided.

brianteeman
brianteeman reviewed Jan 15, 2021
View reviewed changes
README.md Show resolved Hide resolved
brianteeman
brianteeman reviewed Jan 15, 2021
View reviewed changes
README.md Show resolved Hide resolved
brianteeman
brianteeman reviewed Jan 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
brianteeman
brianteeman reviewed Jan 15, 2021
View reviewed changes
compiled/js/skipto.js Outdated Show resolved Hide resolved
brianteeman
brianteeman reviewed Jan 15, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jongund
Copy link
Collaborator Author

jongund commented Jan 19, 2021

@brianteeman
@mpnkhan
Updated the version to 4.0.0 due to changes in color configuration

@brianteeman
Copy link
Collaborator

Why 4.0.0 it should be 4.0.2 as we already have released 4.0.1

skipto/package.json

Line 4 in e0d218c

"version": "4.0.1",

You're local branch is not up to date which is partly what is causing the confusion. It is always best to ensure that you update your branch before working on a pr.

@jongund
Copy link
Collaborator Author

jongund commented Jan 21, 2021

@mpnkhan
Are there any issues blocking this pull request from being merged?

@brianteeman
Copy link
Collaborator

@jongund The current version is 4.0.1 so your change to say 4.0.0 is incorrect and must be either 4.0.2 - also please see #78

@jongund
Copy link
Collaborator Author

jongund commented Jan 21, 2021

@mpnkhan
I have updated the version number to 4.0.2

@jongund
Copy link
Collaborator Author

jongund commented Jan 22, 2021

@jongund The current version is 4.0.1 so your change to say 4.0.0 is incorrect and must be either 4.0.2 - also please see #78

The version in this pull request is 4.0.2

@mpnkhan mpnkhan merged commit 8a98ce3 into paypal:main Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianteeman brianteeman brianteeman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jongund @brianteeman @mpnkhan