Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code coverage and file headers for org.squbs.pattern.spray.japi #65

Closed
akara opened this issue Sep 8, 2015 · 3 comments
Closed

Fix code coverage and file headers for org.squbs.pattern.spray.japi #65

akara opened this issue Sep 8, 2015 · 3 comments
Assignees
@tutufool
Labels
bug fixed
Milestone
RELEASE-0.7.X

Comments

@akara
Copy link
Contributor

akara commented Sep 8, 2015

Two issues with this package:

  1. Many of the files do not have the proper header. This is very important.
  2. The code coverage for this package is absolutely 0. Please build the test cases.
@akara akara added the bug label Sep 8, 2015
@akara akara added this to the RELEASE-0.7.X milestone Sep 8, 2015
@tutufool
Copy link
Contributor

Got it

@tutufool
Copy link
Contributor

There's a JUnit test in org.squbs.pattern.spray.japi called JApiTest.
Is it not picked up by sbt test?

@akara
Copy link
Contributor Author

akara commented Sep 10, 2015

This should have been covered. Let me check whether this test is run
properly.

On Thu, Sep 10, 2015 at 7:13 AM, tutufool notifications@github.com wrote:

There's a JUnit test in org.squbs.pattern.spray.japi called JApiTest.
Is it not picked up by sbt test?

—
Reply to this email directly or view it on GitHub
#65 (comment).

az-qbradley added a commit that referenced this issue Sep 12, 2015
@az-qbradley
Merge pull request #69 from akara/coverage
3c7cb6e 
#65 : Fixed JUnit test coverage.
tutufool pushed a commit to tutufool/squbs that referenced this issue Sep 16, 2015
@zoumuzou
https://github.com/paypal/squbs/issues/65
ee92be6
tutufool pushed a commit to tutufool/squbs that referenced this issue Sep 23, 2015
@zoumuzou
https://github.com/paypal/squbs/issues/65
80ec86c
tutufool pushed a commit to tutufool/squbs that referenced this issue Sep 25, 2015
@zoumuzou
https://github.com/paypal/squbs/issues/65
1f7fdcd
akara added a commit that referenced this issue Sep 25, 2015
@akara
Merge pull request #77 from tutufool/pattern_test
44ac85f 
#65
Cool! Thank you very much for the PR.
@akara akara added the fixed label Sep 29, 2015
@akara akara closed this as completed Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tutufool tutufool

Labels
bug fixed
Projects
None yet
Milestone
RELEASE-0.7.X
Development

No branches or pull requests
2 participants
@akara @tutufool