Continuous payment #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black Duck Security ReportMerging #35 into master will not change security risk. |
|
Code Climate has analyzed commit be8b252 and detected 0 issues on this pull request. View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -106,6 +107,32 @@ private static void createAccountLinkQrCode(final PaymentApi apiInstance){ | |||
| System.out.println(e.getResponseBody()); | |||
| } | |||
|
|
|||
| } | |||
| private static void continuousPaymentFlow(WalletApi walletApiInstance, PaymentApi paymentApi, String userAuthorizationId){ | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -270,6 +297,36 @@ private static PaymentDetails createPayment(final PaymentApi apiInstance, String | |||
| return result; | |||
| } | |||
|
|
|||
| private static PaymentDetails createContinuousPayment(final PaymentApi apiInstance, String merchantPaymentId, | |||
There was a problem hiding this comment.
Method createContinuousPayment has 26 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -106,6 +107,32 @@ private static void createAccountLinkQrCode(final PaymentApi apiInstance){ | |||
| System.out.println(e.getResponseBody()); | |||
| } | |||
|
|
|||
| } | |||
| private static void continuousPaymentFlow(WalletApi walletApiInstance, PaymentApi paymentApi, String userAuthorizationId){ | |||
There was a problem hiding this comment.
Method continuousPaymentFlow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
| @@ -142,15 +146,20 @@ private static void appInvokeFlow(final PaymentApi paymentApi, final WalletApi w | |||
| } | |||
| } | |||
|
|
|||
| private static void directDebitFlow(WalletApi walletApiInstance, PaymentApi paymentApi, String userAuthorizationId){ | |||
| private static void directDebitFlow(WalletApi walletApiInstance, PaymentApi paymentApi, String userAuthorizationId, boolean continuousPayment){ | |||
There was a problem hiding this comment.
Method directDebitFlow has 27 lines of code (exceeds 25 allowed). Consider refactoring.
shreyanshp
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features: