Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated HMAC Auth logic for api with request params, added example cl… #59

Merged
merged 4 commits into from Oct 12, 2020
Merged

updated HMAC Auth logic for api with request params, added example cl… #59

merged 4 commits into from Oct 12, 2020

Conversation

javidlulu
Copy link
Member

…ass for user apis

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

codeclimate[bot]
codeclimate bot reviewed Oct 12, 2020
View reviewed changes
src/main/java/jp/ne/paypay/example/UserApiExample.java Outdated
unlinkUser("userAuthorizationId", userApi);
}

private static void getUserAuthorizationStatus(String userAuthorizationId, UserApi userApi) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

src/main/java/jp/ne/paypay/example/UserApiExample.java Outdated
System.out.println(e.getResponseHeaders());
}
}
private static void unlinkUser(String userAuthorizationId, UserApi userApi) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2020 •
edited

Code Climate has analyzed commit 0a0a7d9 and detected 0 issues on this pull request.

View more on Code Climate.

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #59 into master will not change security risk.

Click here to see full report

@shreyanshp shreyanshp merged commit 24a0d54 into master Oct 12, 2020
@shreyanshp shreyanshp deleted the userauthapis branch October 12, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@shreyanshp shreyanshp shreyanshp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javidlulu @shreyanshp