Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Githubaction bild #72

Merged
merged 16 commits into from
Dec 14, 2020
Merged

Githubaction bild #72

merged 16 commits into from
Dec 14, 2020

Conversation

ashraf-km
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@blackduck-copilot
Copy link

blackduck-copilot bot commented Dec 9, 2020

Black Duck Security Report

Merging #72 into master will not change security risk.

Added Components

Clean: 6

Removed Components

Clean: 4

Click here to see full report

@codeclimate
Copy link

codeclimate bot commented Dec 9, 2020

Code Climate has analyzed commit 98e72a8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (5% is the threshold).

This pull request will bring the total coverage in the repository to 85.1%.

View more on Code Climate.

@shreyanshp
Copy link
Contributor

@ashraf-km , @javidlulu could you also fix the security in the next PR?

./gradlew clean build jacocoTestReport
./gradlew coveralls
- name: Upload to CoPilot
run: bash <(curl -s https://copilot.blackducksoftware.com/ci/githubactions/scripts/upload)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing the post steps as well

  - bash <(curl -s https://copilot.blackducksoftware.com/ci/travis/scripts/upload)
  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, for java code climate is asking to use different command since this has issue with it
https://docs.codeclimate.com/docs/test-coverage-troubleshooting-tips

@javidlulu
Copy link
Member

Fixed blackduck security issue

@shreyanshp shreyanshp merged commit 96a39d0 into master Dec 14, 2020
@shreyanshp shreyanshp deleted the githubaction-bild branch December 14, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants