Merge pull request #225 from paypay/feature/refactor-sdk-v1

Refactor hostname configuration and remove duplicates

src/lib/conf.ts

@@ -1,9 +1,7 @@
-import * as stagingConfig from "./conf.stage.json";
-import * as prodConfig from "./conf.prod.json";
-import * as perfConfig from "./conf.perf.json";
+import * as pathConfig from "./conf.path.json";
+import {HOST_PATH} from "./constants";
 
 export interface Config {
-  HOST_NAME: string;
   PORT_NUMBER?: number;
   API_PAYMENT: {};
   API_WALLET: {};
@@ -17,20 +15,19 @@ export interface Config {
 export class Conf {
   options: { [k: string]: any } = {};
 
-  private readonly stagingConfig: Config = stagingConfig;
-  private readonly prodConfig: Config = prodConfig;
-  private readonly perfConfig: Config = perfConfig;
+  private readonly pathConfig: Config = pathConfig;
 
   private readonly configLookup: any;
 
-  constructor(productionMode: boolean = false, perfMode: boolean = false) {
+  constructor(productionMode: boolean = false, perfMode: boolean) {
+    this.configLookup = JSON.parse(JSON.stringify(this.pathConfig));
     if (productionMode) {
-      this.configLookup = JSON.parse(JSON.stringify(this.prodConfig));
+      this.configLookup.HOST_NAME = HOST_PATH.PROD
     } else {
-      this.configLookup = JSON.parse(JSON.stringify(this.stagingConfig));
+      this.configLookup.HOST_NAME = HOST_PATH.STAGING;
     }
     if (perfMode) {
-      this.configLookup = JSON.parse(JSON.stringify(this.perfConfig));
+      this.configLookup.HOST_NAME = HOST_PATH.PERF_MODE;
     }
   }
 

src/lib/constants.ts

@@ -0,0 +1,5 @@
+export const HOST_PATH = {
+    PROD: 'api.paypay.ne.jp',
+    STAGING: 'stg-api.sandbox.paypay.ne.jp',
+    PERF_MODE: 'perf-api.paypay.ne.jp',
+};

src/lib/paypay-rest-sdk.ts

@@ -16,7 +16,7 @@ class PayPayRestSDK {
   private options: any = "";
   private productionMode: boolean = false;
   private perfMode: boolean = false;
-  private auth: Auth;
+  private readonly auth: Auth;
   private config: Conf;
 
   constructor() {