Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes all GET methods failure #69

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

masatomo
Copy link
Contributor

@masatomo masatomo commented Sep 9, 2020

Authorization header was not created properly for GET methods.

  • body is not required for GET
  • request path was not replaced with parameters

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Authorization header was not created properly.
* body is not required for GET
* request path was not replaced with parameters
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2020

CLA assistant check
All committers have signed the CLA.

@codeclimate
Copy link

codeclimate bot commented Sep 9, 2020

Code Climate has analyzed commit da0c8c9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #69 into master will not change security risk.

Click here to see full report

@shreyanshp
Copy link
Contributor

Looks good, thank you so much @masatomo
Glad to have you here!

@shreyanshp shreyanshp merged commit 663b0f7 into paypay:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants