Feature/pp 44628 #47
Feature/pp 44628 #47
Conversation
- Test fixes - Local mock setup for payment get,create and cancel - Fix for payment controller using wrong endpoint
Conflicts: src/Controllers/Payment.php src/Controllers/Refund.php
- Added missing constuctor to pending payment payload
Black Duck Security ReportMerging #47 into master will not change security risk. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * @param CreatePendingPaymentPayload $payload SDK payload object | ||
| * @return mixed | ||
| */ | ||
| public function createPendingPayment($payload) |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| * @return mixed | ||
| */ | ||
| public function getPaymentDetails($merchantPaymentId) | ||
| public function getPaymentDetails($merchantPaymentId, $paymentType = 'web_cashier') |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| * @return mixed | ||
| */ | ||
| public function cancelPayment($merchantPaymentId) | ||
| public function cancelPayment($merchantPaymentId, $paymentType = 'web_cashier') |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit feaf1eb and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (5% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (0.4% change). View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Let's fix the quality issues in next PR @paypay-ayas |
All Submissions:
New Feature Submissions:
Changes to Core Features: