Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ci actions #85

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Build ci actions #85

merged 3 commits into from
Dec 14, 2020

Conversation

javidlulu
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #85 into master will not change security risk.

Click here to see full report

Copy link
Contributor

@ashraf-km ashraf-km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Comment on lines +25 to +29
- name: Before script
run: |
curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
chmod +x ./cc-test-reporter
./cc-test-reporter before-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this go before Run tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

run: make coverall_upload

- name: Upload to CoPilot
run: bash <(curl -s https://copilot.blackducksoftware.com/ci/githubactions/scripts/upload)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have missed codeclimate in post steps, please check the travis.yml once and make sure we have all the scripts and features migrated to github actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added codeclimate post script

@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented Dec 11, 2020

Code Climate has analyzed commit c0b228c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (5% is the threshold).

This pull request will bring the total coverage in the repository to 93.6%.

View more on Code Climate.

@shreyanshp shreyanshp merged commit a5180e6 into master Dec 14, 2020
@shreyanshp shreyanshp deleted the build-ci-actions branch December 14, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants