Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response usage #67

Merged
merged 1 commit into from May 7, 2021
Merged

Fix response usage #67

merged 1 commit into from May 7, 2021

Conversation

Alpaca131
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alpaca131 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@grarich grarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alpaca131
Copy link
Author

#66 Fixed this issue.

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #67 into master will not change security risk.

Click here to see full report

1 similar comment
@blackduck-copilot
Copy link

Black Duck Security Report

Merging #67 into master will not change security risk.

Click here to see full report

@javidlulu javidlulu requested a review from solancer May 6, 2021 06:17
Copy link
Contributor

@shreyanshp shreyanshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Alpaca131 and @solancer

@shreyanshp
Copy link
Contributor

shreyanshp commented May 7, 2021

@Alpaca131

It seems your commit was not linked to the github account
Anyway I could see in cla-assistant that you did sign the cla so I will merge this for now

@shreyanshp shreyanshp merged commit 215f028 into paypay:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants