Skip to content

Commit

Permalink
resolve #5 - shift VERSION variable into main package
Browse files Browse the repository at this point in the history
Fix VERSION confusion by moving $Business::GoCardless::VERSION into the
main module to avoid parts of the cpan(m|ts) toolchain getting confused

(VERSION_FROM was correct in the Makefile.PL so i don't know why this is
an issue but whatever)
  • Loading branch information
leejo committed Jun 8, 2017
1 parent c2c1e17 commit 8950a12
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 38 deletions.
6 changes: 6 additions & 0 deletions Changes
@@ -1,5 +1,11 @@
Revision history for Business-GoCardless

0.19 2017-06-08
- Fix documentation typos
- Fix VERSION confusion by moving $Business::GoCardless::VERSION
into the main module to avoid parts of the cpan(m|ts) toolchain
getting confused

0.18 2017-06-06
- Fix documentation typos

Expand Down
1 change: 0 additions & 1 deletion MANIFEST
Expand Up @@ -19,7 +19,6 @@ lib/Business/GoCardless/Utils.pm
lib/Business/GoCardless/Webhook.pm
lib/Business/GoCardless/Webhook/V2.pm
lib/Business/GoCardless/Webhook/Event.pm
lib/Business/GoCardless/Version.pm
Makefile.PL
MANIFEST
README.md
Expand Down
2 changes: 1 addition & 1 deletion Makefile.PL
Expand Up @@ -7,7 +7,7 @@ use ExtUtils::MakeMaker;

WriteMakefile(
NAME => 'Business::GoCardless',
VERSION_FROM => 'lib/Business/GoCardless/Version.pm',
VERSION_FROM => 'lib/Business/GoCardless.pm',
AUTHOR => 'Lee Johnson <leejo@cpan.org>',
LICENSE => 'perl',
MIN_PERL_VERSION => '5.10.1',
Expand Down
6 changes: 3 additions & 3 deletions lib/Business/GoCardless.pm
Expand Up @@ -11,7 +11,7 @@ set of modules
=head1 VERSION
0.18
0.19
=head1 DESCRIPTION
Expand Down Expand Up @@ -48,13 +48,13 @@ use strict;
use warnings;

use Moo;
with 'Business::GoCardless::Version';

use Carp qw/ confess /;

use Business::GoCardless::Client;
use Business::GoCardless::Webhook;

$Business::GoCardless::VERSION = '0.19';

has api_version => (
is => 'ro',
required => 0,
Expand Down
2 changes: 1 addition & 1 deletion lib/Business/GoCardless/Client.pm
Expand Up @@ -16,7 +16,6 @@ use warnings;

use Moo;
with 'Business::GoCardless::Utils';
with 'Business::GoCardless::Version';

use Business::GoCardless::Exception;
use Business::GoCardless::Bill;
Expand Down Expand Up @@ -165,6 +164,7 @@ has user_agent => (
default => sub {
my ( $self ) = @_;
# maybe want more info in here, version of perl, platform, and such
require Business::GoCardless;
return "business-gocardless/perl/v"
. $Business::GoCardless::VERSION
. "-" . $self->api_version
Expand Down
32 changes: 0 additions & 32 deletions lib/Business/GoCardless/Version.pm

This file was deleted.

0 comments on commit 8950a12

Please sign in to comment.