Refactoring OCDSpecExpectation and custom matchers #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2012 16:21
Matchers use failWithMessage failWithMessage made public
paytonrules
pushed a commit
that referenced
this pull request
May 25, 2012
Refactoring OCDSpecExpectation and custom matchers - thanks Eric Meyer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up in merge hell, so I made a new branch and put my changes in here. There were four commits, but now there are two. The first one was made irrelevant because of changes you made, and the last change I was having trouble re-implementing. Here are the middle two, with the added specs for failWithMessage.