-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine-grained reproduce flags and testing #204
Conversation
tests can be independent of model driver implementation. A platonic ideal if you will. Added config options for fine-grained reproduce options. Input, exe and restart reproduce can be turned on independently of each other. Added extensive testing of init/setup and reproduce.
Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-17 00:32:10 UTC |
Added new test to travis, and pytest dependency.
@marshallward I've moved the pbs environment init function to (The PBS install stuff seems to be broken BTW. It couldn't find |
I think a lot of that was cut-and-paste from the bundled Python bootstrap script. Not sure why it isn't working, might need looking into. Is there not some way to retain 2.7 and 3.5 testing? I don't know if removing versions is the right path foward here. |
Are you dropping 2.7 to use |
Sorry, I thought we'd decided to drop 2.7 support, as people could always use an older version? All the tests I just wrote are not python2 compatible as they use |
Ah yeah, ok, it's just the test itself. All good, just wondering how things might work if I ever try porting payu to Gaea. |
Could have version dependent tests where the 2.7 test just does https://github.com/payu-org/payu/blob/master/conda/meta.yaml#L34 to make sure there are no breaking changes to Do you only have access to |
isn't python2 compliant. Just use local mkdir_p function. Initialise existing_files attribute to empty set so no need to check if the attribute exists. Avoids spurious pylint errors.
error about CalledProcessError not having errno attribute, but also cleaner to separate into different except blocks.
So now the tests will do Additionally for python3.x interpreters |
make more error resistant
Added more tests to exe and input reproduce to clarify logic for corner cases
RemoveError: 'setuptools' is a dependency of conda and cannot be removed from conda's operating environment.
correctly and sometimes throws random errors when the source can't be found. Added back in payu_test.py to tests.
Added test model for ... testing. Has minimal requirements and means
tests can be independent of model driver implementation. A platonic
ideal if you will.
Added config options for fine-grained reproduce options. Input, exe
and restart reproduce can be turned on independently of each other.
Added extensive testing of init/setup and reproduce.
Fixes #203