Added routine to return correct storage string and test #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-06 00:20:38 UTC |
|
Not finished as yet, but created a routine to strip out necessary storage strings. |
Updated tests. PEP8 fixes.
Made PBS call testable by returning string for cli to execute. Added test for generate_command routine. Used argparse to facilitate checking. Moved all PBS related tests to a new test script.
Created two separate routines, encode_mount and make_mount_string, and wrote tests. pbs.generate_command now takes an optional python interpreter path to allow arbitrary paths to be passed for testing. Changed to a regular expression to parse mounts in find_mounts. Explicitly do not support mount paths that have no subdirectories under project code, or no trailing slash.
Made get_all_fullpaths to Manifest to access all fullpaths. Required to support checking paths for storage flags using PBS at NCI.
Made separate load method that will load whatever manifests are available. Logic for checking for reproduce consistency is all contained in setup. Create separate init_mf method for initialising submanifests and use this to zero off other manifests when loaded versions not required. Streamlined code in manifest init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215