-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added force option to setup and run #256
Conversation
work directory. Changed default of reproduce option to False from None.
Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-08 09:26:20 UTC |
This isn't finished yet. Have to make a test. Also haven't made output overwrite. @marshallward do we want to add that too? I'm broadly in favour, just wanted to check. |
I don't know how output override would work, since if a run crashed then there ought not be an output directory. (If there were then I'd consider it a bug). But if there's some problem I can't see that you think it will solve, then I reckon it's alright. |
Not really. The instructions say you can |
So it is solving a different problem. |
OK, then I could see how it could be useful. I had never used the |
Maybe do that in a different PR I guess, rather than overload this one right now? |
Sounds good, smaller is better! |
Still have to add a test, which I'll do tomorrow as I am off for now. Thanks for the feedback @marshallward |
generate_parser routine and tests for most commonly used command line options.
Well I went a bit mad and added a bunch of command line argument tests, which did show up a weird errant option that was not a bug but was not correct. Pretty happy with the resulting tests. Not testing all commands, but easy enough to add them in if you feel so inclined. |
I reckon I'll just go ahead and merge this @marshallward |
Added force option to setup and run. Automatically removes existing work directory. Closes #255.
Also hanged default of reproduce option to False from None.